Closed
Conversation
michalChrobot
approved these changes
Apr 1, 2025
Member
michalChrobot
left a comment
michalChrobot
left a comment
There was a problem hiding this comment.
Nice! But if I understand correctly those exceptions should still be present pets.pvp-catalog right (for release purposes)?
Member
|
Actually as I was talking with @NoelStephensUnity we want to make those Test related APIs internal which should resolve this problem without having filter.yml (otherwise a nice solution) so I would hold for a bit with merging and I will follow up on this |
Member
|
We got approval to change the test classes to internal for the next release which should fix the problem. I will close this PR and I will come back to it IF we will have some problems with doing the change (then this would be a next in line solution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a filter.yml file that filters out tests from the pvp API documentation checks automatically. This prevents us from having to add a pvpException for all namespaces that contain
Testin the name.